Additional langtitle parsing issue

[vBET]

Nevermind- found another: translated PM titles aren't parsed in the page titles on private.php

Fixed by adding a plugin at private_complete:

if (strpos($pagetitle, '[/langtitle]')) {
require_once(DIR. '/includes/vbenterprisetranslator_functions_bbcode.php');
$pagetitle = vbet_parseTitle($pagetitle);
} 

I really cannot reproduce this issue on our server. I suspect that you do not have installed appropriately vBET 3.3.3 - please check it. We had many times issue that our clients just uploaded new files and forgot to import new product file or the opposite. Did you checked does execution of function vbet_global_complete exist in described place? (http://www.vbenterprisetranslator.co....html#post3137)

Also we are running our forums now on vBET 3.3.4 beta version, so it can be that bug exist in 3.3.3 and we already fixed it (do not remember that). Still -please confirm that your actual installation is OK - best made update to 3.3.3 again.

[vBET]

And another:



I couldn't find a way to fix this via plugins. Instead, I added this code to usercp.php:

if (strpos($reputation['title'], '[/langtitle]')) {

            require_once(DIR. '/includes/vbenterprisetranslator_functions_bbcode.php');

            $reputation['title'] = vbet_parseTitle($reputation['title']);

        } 

Directly below

        
$reputation['timeline'] = vbdate($vbulletin->options['timeformat'], $reputation['dateline']);

        $reputation['dateline'] = vbdate($vbulletin->options['dateformat'], $reputation['dateline']);

        $reputation['reason'] = $bbcode_parser->parse($reputation['reason']); 

If this page is using global_complete hook then it should be handled in vBET 3.3.3 - please see previous response about that. If global_complete is not used - then such file change will be necessary or you can add it to some hook if there exist some on this page.

[moman]

My product file and all the PHP files are showing up as v3.3.3, as they should be. However, I have modified many files and have quite a few plugins installed on my forum, so it's somewhat likely that there may be a conflict.

I've noticed that the execution time on the global_complete hook is 1000. Shouldn't this be higher to avoid conflicting with other plugins?

[moman]

I've confirmed the presence of the global parsing function. I very carefully upgraded to 3.3.3, so I doubt that file contents can be an issue here. However, I see no further bugs, so I think I'm good for the time-being.

I'm also happy to say that vBET's performance hit on my server is negligible, so I may not be upgrading past 3.3.3 due to the high number of customizations/working fixes I've implemented on my own. With 800 online, I've had server loads below 1.00, and with 1,200 online, they were around 3.00. Not bad for a dual hex-core Xeon server, I think!

[vBET]

I think too!

So - getting back to the issue. vBET should handle automatically those cut langtitle (with ...) - we are not able to reproduce it on our forums and want to made new release soon. It would be great if we could find the reason of this and fix it if it is on our side. If you can PM access detail to your forum, or even your test instance where those things happen we could to that - we could fix it

At this moment without possibility to reproduce we even cannot be sure does it is really vBET bug (not some conflict with other mod or configuration issue). So we are in dead point now in this area. Once again - we would gladly solve this issue on your side if you will. There is possibility that new vBET release will be this weekend - would be great to close all issues before

[vBET]

I found that we really had a bug there. Global langtitle parsing was inside of unnecessary condition so it not always was evaluated. This is already corrected and will be included in next release.

[moman]

Could you please post a quick fix for that? I can't upgrade to 3.3.4 right now

I'm guessing that the unnecessary condition is the one below:

function vbet_parseTitleGlobally(&$title, $removeNotTranslateSection = false) {

if ($_GET['do'] != 'postthread' && $_GET['do'] != 'comment' && 0!==strpos($_GET['do'], 'edit') && 0!==strpos($_GET['do'], 'update')

&& strpos($title, '[langtitle=')) {

return vbet_parseTitleMultiple($title, $removeNotTranslateSection);

} 

[vBET]

What hold you with update?

I will look in out SVN to check what changes was made to solve the issue, but still - you will need last release first to be able to made quick fix if we publish it.

[moman]

I've made several modifications to the code over time, and I've forgotten where and why. I don't want to be breaking things that already work!

[vBET]

Please note that we are not responsible for code changed by our clients - we are simple not able to do that. If your changes was according to our quick fixes then you can be calm - those will be included in next release so everything will be OK. If you made some other code changes, then we advice to write some document which will guide you about your personal additional steps during updates - otherwise you will stay with old vBET version, because you o not know what and what for you changed.

Please note that I found what changes are necessary to solve this issue, but I cannot publish quik fix on forum (because it includes broken bbcode inside). So pelase ask about it by email (contact@vbenterprisetranslator.com) and I will send it to you there.